Differential D24842

Use the text "OK" instead of "Proceed" in updates dialog when things go wrong
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 7:05 PM.

Details

Reviewers
apol
filipf
Group Reviewers
VDG
Discover Software Store
Commits
R134:62d595f24db6: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong
Summary

Otherwise the button says "Proceed" when the dialog is showing you an error condition
in which you cannot proceed:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 21 2019, 7:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 7:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 7:05 PM
filipf accepted this revision.Oct 21 2019, 9:59 PM
filipf added a subscriber: filipf.

Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here?

This revision is now accepted and ready to land.Oct 21 2019, 9:59 PM
Closed by commit R134:62d595f24db6: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong (authored by ngraham). · Explain WhyOct 21 2019, 10:00 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Oct 22 2019, 1:02 AM
In D24842#551772, @filipf wrote:

Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here?

Yeah I need to fix that too.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (2 lines)

Diff 68492

View Options

discover/qml/UpdatesPage.qml

Loading...