Differential D24839

Only show "Unlock Widgets" in the UI, not "Lock Widgets"
ClosedPublic
Actions

Authored by GB_2 on Oct 21 2019, 5:36 PM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
VDG
Commits
R120:f9a664cfd898: Only show "Unlock Widgets" in the UI, not "Lock Widgets"
Summary

Not needed for normal users with the new edit mode system.

Test Plan

Lock the widgets before compiling this patch. Then compile with it, unlock widgets and see that there is no lock option in the panel context menu.

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D24839
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17998
Build 18016: arc lint + arc unit
GB_2 created this revision.Oct 21 2019, 5:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 5:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Oct 21 2019, 5:36 PM
ngraham added a subscriber: ngraham.Oct 21 2019, 7:08 PM

Also needs a rebase

ngraham accepted this revision.Oct 21 2019, 7:10 PM
This revision is now accepted and ready to land.Oct 21 2019, 7:10 PM
GB_2 updated this revision to Diff 68480.Oct 21 2019, 7:12 PM

Rebase

GB_2 added a reviewer: mart.Oct 21 2019, 7:12 PM
GB_2 added a subscriber: mart.
ngraham accepted this revision.Oct 21 2019, 7:18 PM
broulik added a subscriber: broulik.Oct 22 2019, 7:13 AM
broulik added inline comments.
containmentactions/contextmenu/menu.cpp
146

Please avoid negating entire boolean statements.

Instead of !(foo && bar) use !foo || !bar

GB_2 updated this revision to Diff 68510.Oct 22 2019, 9:05 AM

Avoid negating entire boolean statements

GB_2 marked an inline comment as done.Oct 22 2019, 9:05 AM
ngraham accepted this revision.Oct 26 2019, 9:40 PM

This will unclutter the context menu a bit, +1

GB_2 added 1 blocking reviewer(s): mart.Oct 29 2019, 4:26 PM
This revision now requires review to proceed.Oct 29 2019, 4:26 PM
mart accepted this revision.Oct 29 2019, 4:43 PM
This revision is now accepted and ready to land.Oct 29 2019, 4:43 PM
Closed by commit R120:f9a664cfd898: Only show "Unlock Widgets" in the UI, not "Lock Widgets" (authored by GB_2). · Explain WhyOct 29 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.
GB_2 mentioned this in R119:88bce0e49c7e: Hide "Lock Widgets" button from panel edit mode toolbar.

Revision Contents
Changeset List

Diff 68480

View Options

containmentactions/contextmenu/menu.cpp

Loading...