Differential D24832

Re-add category display to app delegates
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 2:12 PM.

Details

Reviewers
apol
Group Reviewers
VDG
Discover Software Store
Commits
R134:9dc1768ac897: Re-add category display to app delegates
Summary

A year ago, I removed this in 0911fbcd561c with no review. :/ Sorry about that. In the
past year, Discover's UI has come a long way, and I think we can re-add the category
display now without causing the app delegates to become super cluttered.

The category name is suppressed if it would be identical to the page's title.

Test Plan

Categories in search lists:


Categories on the featured page:

Categories in browse lists, featuring suppression-when-equal-to-the-page-title:

Diff Detail

Repository
R134 Discover Software Store
Branch
re-add-categories-display-on-delegate (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17973
Build 17991: arc lint + arc unit
ngraham created this revision.Oct 21 2019, 2:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 2:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 2:12 PM
apol accepted this revision.Oct 21 2019, 2:20 PM

Let's try and see what it feels like

discover/qml/ApplicationDelegate.qml
77

just Layout.fillWidth: !category.visible.

This revision is now accepted and ready to land.Oct 21 2019, 2:20 PM
ngraham updated this revision to Diff 68443.Oct 21 2019, 2:44 PM
ngraham marked an inline comment as done.

Simplify layout conditional

Closed by commit R134:9dc1768ac897: Re-add category display to app delegates (authored by ngraham). · Explain WhyOct 21 2019, 2:45 PM
This revision was automatically updated to reflect the committed changes.
• ghost34 added a subscriber: • ghost34.Oct 28 2019, 5:47 PM

Could add the more appropriate icons for categories?

I found some Breeze icons that should looks good with category name.

Color Schemes:


Emoticons:

Fonts:

GTK 2/3.x Themes:

Splash Screens:

This could to be discussed in T10891.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationDelegate.qml (27 lines)

Diff 68439

View Options

discover/qml/ApplicationDelegate.qml

Loading...