Differential D2483

Ensure to directly delete old Shadow on update
ClosedPublic
Actions

Authored by graesslin on Aug 18 2016, 2:08 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:fe8fc6f83d3a: Ensure to directly delete old Shadow on update

Summary

So far when deleting a Shadow we used deleteLater which caused it
to be deleted in the next event cycle. This could in worst case result
in the Shadow being deleted after compositing got suspended. Thus the
Shadow not getting removed from the DecorationShadowCache which in
turn would mess up rendering on resume of compositing as the cache
returns a texture created for a different context.

BUG: 361154
FIXED-IN: 5.7.4

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 6034.Aug 18 2016, 2:08 PM

graesslin retitled this revision from to Ensure to directly delete old Shadow on update.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptAug 18 2016, 2:08 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

Code fine. Tested on live system.

This revision is now accepted and ready to land.Aug 19 2016, 1:08 AM

Closed by commit R108:fe8fc6f83d3a: Ensure to directly delete old Shadow on update (authored by graesslin). · Explain WhyAug 19 2016, 5:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			scene.h (6 lines)
M			scene.cpp (9 lines)
M			shadow.cpp (7 lines)

Diff 6055

scene.h

Loading...

scene.cpp

Loading...

shadow.cpp

Loading...