Differential D24819

KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration
ClosedPublic
Actions

Authored by crossi on Oct 21 2019, 8:31 AM.

Details

Reviewers
ervin
mart
bport
Group Reviewers
Plasma
Commits
R119:1b857f927037: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method…
Summary

Clean up before moving LnF KCM to KConfigXT

Test Plan

Compile

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi requested review of this revision.Oct 21 2019, 8:31 AM
crossi created this revision.
crossi edited the test plan for this revision. (Show Details)Oct 21 2019, 8:35 AM
bport requested changes to this revision.Oct 21 2019, 8:40 AM
bport added inline comments.
kcms/lookandfeel/kcm.cpp
223

I think we can keep this blank line

235

Not needed

This revision now requires changes to proceed.Oct 21 2019, 8:40 AM
ervin requested changes to this revision.Oct 21 2019, 8:46 AM

LGTM apart from what bport said.

kcms/lookandfeel/kcm.h
43

Wow, that's a lot of unused properties, good catch. :-)

crossi updated this revision to Diff 68416.Oct 21 2019, 10:18 AM

restore blank lines

Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 10:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin accepted this revision.Oct 21 2019, 11:07 AM
bport accepted this revision.Oct 22 2019, 11:06 AM
This revision is now accepted and ready to land.Oct 22 2019, 11:06 AM
Closed by commit R119:1b857f927037: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method… (authored by crossi). · Explain WhyOct 22 2019, 12:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/lookandfeel/kcm.h (43 lines)
Mkcms/lookandfeel/kcm.cpp (104 lines)

Diff 68536

View Options

kcms/lookandfeel/kcm.h

Loading...
View Options

kcms/lookandfeel/kcm.cpp

Loading...