Differential D24815

[Weather] Make update time spinbox editable
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 1:55 AM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Commits
R114:ec2392dbf70a: [Weather] Make update time spinbox editable
Test Plan

Now you can enter text in it using the keyboard. To make this more predictible, the
custom stepSize value is removed so all integer valued between the min and max are
acceptable now.

Diff Detail

Repository
R114 Plasma Addons
Branch
editable-spinbox (branched from Plasma/5.17)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17986
Build 18004: arc lint + arc unit
ngraham created this revision.Oct 21 2019, 1:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 1:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 1:55 AM
ngraham updated this revision to Diff 68462.Oct 21 2019, 5:02 PM

Add a valueFromText handler

ngraham added a comment.Oct 21 2019, 5:04 PM

Landing without approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2019, 5:04 PM
Closed by commit R114:ec2392dbf70a: [Weather] Make update time spinbox editable (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68462

View Options

applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

Loading...