[KCMs] Make spinboxes editable
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 1:47 AM.

Details

Reviewers

None

Group Reviewers

VDG
Plasma

Commits

R119:4f90a137e7a3: [KCMs] Make spinboxes editable

Summary

Otherwise they're annoying to use because you can only interact with them using a scroll
or by clicking on the tiny arrows.

Test Plan

You can now enter text in the spinboxes

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.Oct 21 2019, 1:47 AM

Add valueFromText handlers

Landing without explicit approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2019, 5:17 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcms/fonts/package/contents/ui/main.qml (4 lines)
M			kcms/launch/package/contents/ui/main.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68397	6b4295b		Oct 21 2019, 1:47 AM	★	★
Diff 2	68464	6b4295b	Add valueFromText handlers	Oct 21 2019, 5:11 PM	★	★
Diff 3	68465	6b4295b	R119:4f90a137e7a3a0e7b0c53bd1811934da49f59bd5	Oct 21 2019, 5:17 PM	★	★