Disable keyboard accelerators for the tabs widget
ClosedPublic

Authored by alexmi on Oct 20 2019, 9:55 AM.

Details

Summary

Now that there are actions for switching to a specific tab with default
Alt + <number> shortcuts, automatically assigned keyboard accelerators
can result in ambiguous shortcuts when using specific tab names
containing numbers.

Not adding any accelerators for the tabs widget ensures the default
shortcuts work reliably regardless of tab names.

Test Plan
  • Verify there are no ambiguous shortcuts when browsing folders with

names containing only numbers

  • Verify other keyboard accelerators still work (menu bar, context menu

and others)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexmi created this revision.Oct 20 2019, 9:55 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 20 2019, 9:55 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alexmi requested review of this revision.Oct 20 2019, 9:55 AM
ngraham accepted this revision as: VDG, ngraham.Oct 21 2019, 3:37 AM
ngraham added a subscriber: ngraham.
This revision is now accepted and ready to land.Oct 21 2019, 3:37 AM
elvisangelaccio accepted this revision.Oct 21 2019, 7:40 PM
This revision was automatically updated to reflect the committed changes.