Differential D24790

settings/konqhtml: use the in-tree ktabwidget class
ClosedPublic
Actions

Authored by ahmadsamir on Oct 19 2019, 9:03 PM.

Details

Reviewers
dfaure
stefanocrocco
Maniphest Tasks
T11559: Port Konqueror away from KDELibs4Support
Commits
R226:7e796febd29c: settings/konqhtml: use the in-tree ktabwidget class
Test Plan

The code compiles

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Oct 19 2019, 9:03 PM
ahmadsamir created this revision.
dfaure requested changes to this revision.Oct 20 2019, 10:13 AM

This looks wrong. This code doesn't need KTabWidget (which has webbrowser-specific features), it should be ported to QTabWidget instead.

This revision now requires changes to proceed.Oct 20 2019, 10:13 AM
ahmadsamir added a comment.Oct 20 2019, 11:01 AM
In D24790#550507, @dfaure wrote:

This looks wrong. This code doesn't need KTabWidget (which has webbrowser-specific features), it should be ported to QTabWidget instead.

OK, will do. :)

ahmadsamir updated this revision to Diff 68350.Oct 20 2019, 11:21 AM

Use QTabWidget instead of KTabWidget

dfaure accepted this revision.Oct 20 2019, 11:23 AM
This revision is now accepted and ready to land.Oct 20 2019, 11:23 AM
Closed by commit R226:7e796febd29c: settings/konqhtml: use the in-tree ktabwidget class (authored by ahmadsamir). · Explain WhyOct 20 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68356

View Options

settings/konqhtml/appearance.cpp

Loading...
View Options

settings/konqhtml/filteropts.h

Loading...
View Options

settings/konqhtml/filteropts.cpp

Loading...