Differential D24789

More ktabwidget fixes
ClosedPublic
Actions

Authored by ahmadsamir on Oct 19 2019, 9:01 PM.

Details

Reviewers
dfaure
stefanocrocco
Maniphest Tasks
T11559: Port Konqueror away from KDELibs4Support
Commits
R226:0a0b1a773ffc: More ktabwidget fixes
Summary

Remove closeRequest() declarations as it is replaced with tabCloseRequest().

Use qCWarning() instead of kWarning().

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Oct 19 2019, 9:01 PM
ahmadsamir created this revision.
ahmadsamir updated this revision to Diff 68332.Oct 20 2019, 9:16 AM

movedTab signal is redundant

dfaure accepted this revision.Oct 20 2019, 9:58 AM

Hmm, right, as long as we link to kdelibs4support, we have a conflict on the classname KTabWidget. I should have put it into a namespace or renamed it KonqTabWidget...

This revision is now accepted and ready to land.Oct 20 2019, 9:58 AM
ahmadsamir updated this revision to Diff 70248.Nov 24 2019, 7:52 AM
ahmadsamir retitled this revision from Fix in-tree ktabwidget to More ktabwidget fixes.
ahmadsamir edited the summary of this revision. (Show Details)

Rebase; some of the fixes were redone by dfaure, so we just rebase this one on top of master.

Closed by commit R226:0a0b1a773ffc: More ktabwidget fixes (authored by ahmadsamir). · Explain WhyNov 24 2019, 7:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ktabwidget.h (9 lines)
Msrc/ktabwidget.cpp (4 lines)

Diff 70249

View Options

src/ktabwidget.h

Loading...
View Options

src/ktabwidget.cpp

Loading...