[SystemTray] Support for AttentionIcon
ClosedPublic

Authored by kmaterka on Oct 18 2019, 10:08 PM.

Details

Summary

Adding support for Attention Icon to StatusNotifier tray icons

BUG: 341255

Test Plan

As described in bug report, Konversation can be used for tests.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17881
Build 17899: arc lint + arc unit
kmaterka created this revision.Oct 18 2019, 10:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2019, 10:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 18 2019, 10:08 PM
davidedmundson accepted this revision.Oct 19 2019, 12:25 AM
This revision is now accepted and ready to land.Oct 19 2019, 12:25 AM
ngraham accepted this revision.Oct 19 2019, 2:34 AM
ngraham edited reviewers, added: apol, mart; removed: Plasma: Workspaces.
This revision was automatically updated to reflect the committed changes.

Doesn't this break the binding for source? My tray icons don't update anymore

Doesn't this break the binding for source? My tray icons don't update anymore

Hmm, I will test that. It is possible :/ Definitely there is something wrong with PlasmaCore.IconItem.source binding. AttentionIcon was not shown when I did:

PlasmaCore.IconItem {
        id: iconItem
        source: status === PlasmaCore.Types.NeedsAttentionStatus ? (AttentionIcon ? AttentionIcon : AttentionIconName) : (Icon ? Icon : IconName)

Doesn't this break the binding for source? My tray icons don't update anymore

Fix in D24865, sorry...