[KEditFileType] Add a desktop file
ClosedPublic

Authored by meven on Oct 18 2019, 1:25 PM.

Details

Summary

Allow to display its Icon in Wayland
BUG: 383615

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Oct 18 2019, 1:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2019, 1:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Oct 18 2019, 1:25 PM
meven updated this revision to Diff 68239.Oct 18 2019, 1:25 PM

Add missing .desktop file

meven retitled this revision from Add a desktop for utility keditfiletype to [KEditFileType] Add a desktop file.Oct 18 2019, 1:27 PM

Should this be NoDisplay since you can't just launch it without an argument

kossebau added inline comments.
keditfiletype/CMakeLists.txt
57

KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. https://api.kde.org/ecm/kde-module/KDEInstallDirs.html

meven updated this revision to Diff 68243.Oct 18 2019, 2:15 PM

Replace OnlyShowIn= by NoDisplay=true USe KDE_INSTALL_APPDIR instead of deprecated XDG_APPS_INSTALL_DIR

meven marked an inline comment as done.Oct 18 2019, 2:16 PM
broulik accepted this revision.Oct 18 2019, 2:16 PM
This revision is now accepted and ready to land.Oct 18 2019, 2:16 PM
meven added inline comments.Oct 18 2019, 2:19 PM
keditfiletype/CMakeLists.txt
57

We have a bunch of apps to update, I used this because I found it in krusader code

kossebau added inline comments.Oct 18 2019, 2:32 PM
keditfiletype/CMakeLists.txt
57

Yes, due to having no proper cmake deprecation warnings there are still some with old code. But lots of porting already happened :)

Perhaps KDE_INSTALL_DIRS_NO_DEPRECATED should be started to be enforced on CI :)

This revision was automatically updated to reflect the committed changes.