Make non-ignorable SSL errors explicit
ClosedPublic

Authored by vkrause on Oct 17 2019, 4:38 PM.

Details

Summary

So far this is done implicitly in KSSLD by not being able to persist
these error codes in its config file. This however is rather error
prone, and requires manual enum <-> string mapping there.

Now we do this explicitly, which allows us to eventually use QMetaEnum
for serialization in KSSLD.

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17822
Build 17840: arc lint + arc unit
vkrause created this revision.Oct 17 2019, 4:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 17 2019, 4:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Oct 17 2019, 4:38 PM
apol added a subscriber: apol.Oct 17 2019, 5:49 PM

LGTM otherwise

src/core/ksslcertificatemanager.cpp
537

return ret; ;)

vkrause updated this revision to Diff 68248.Oct 18 2019, 3:55 PM

Fix return value.

vkrause updated this revision to Diff 68289.Oct 19 2019, 10:51 AM

Rebase on recent changes.

Anyone? This blocks the subsequent SSL error patches.

apol accepted this revision.Oct 29 2019, 6:08 PM
This revision is now accepted and ready to land.Oct 29 2019, 6:08 PM
This revision was automatically updated to reflect the committed changes.