Correctly highlight the icon in the system tray

Authored by kmaterka on Oct 17 2019, 2:19 PM.



Icon is highlighted when CapsLock or NumLock are locked. It should not
be used this way, icon should be highlithed on mouse hover, as any other
icon in system tray.

CCBUG: 400295

Test Plan

Hover mouse over the icon - highlight only when mouse is over the icon. It should not highlight when CapsLock or NumLock are used.

Diff Detail

R114 Plasma Addons
No Linters Available
No Unit Test Coverage
Build Status
Buildable 17813
Build 17831: arc lint + arc unit
kmaterka created this revision.Oct 17 2019, 2:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2019, 2:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 17 2019, 2:19 PM
kmaterka edited the test plan for this revision. (Show Details)Oct 17 2019, 2:30 PM
ngraham accepted this revision.Oct 17 2019, 4:15 PM
This revision is now accepted and ready to land.Oct 17 2019, 4:15 PM

Interestingly the very original code was

+ active: parent.containsMouse || root.capsLock

The rationale, I assume was because number lock takes precedent over caps lock in the icon, so this gives you a way of seeing when you have both. Albeit not a very intuitive one.

This revision was automatically updated to reflect the committed changes.