The webpage structure of NOAA changed so the old regular expression doesn't work anymore. Updated it. But it can break in future again.
BUG: 408580
sitter |
Plasma |
The webpage structure of NOAA changed so the old regular expression doesn't work anymore. Updated it. But it can break in future again.
BUG: 408580
No Linters Available |
No Unit Test Coverage |
Buildable 17797 | |
Build 17815: arc lint + arc unit |
Still broken, I'm afraid. Among the console output is the following, which may be helpful:
kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
The url in my patch is QStringLiteral("https://www.nesdis.noaa.gov") + result.captured(1);. So it must begin with https://.
I don't know what to tell you; it's still broken for me. It looks like the first part of the URL isn't getting added onto the second, maybe.
When I put the code in a minimal standalone program I can confirm that the code works just fine. Are you sure your testing methodology is sound @ngraham ?
In point of fact
if (url.isEmpty()) {
should actually be url.isValid because the requirement is not just that it needs to be nonempty but also valid. When changed, that condition would show more clearly that the right code is run as the KIO warning should disappear.
If it works for you @sitter then feel free to ignore me. But I believe my testing methodology is sound: I'm living in my built-from-source plasma session and I apply the patch, build and install kdeplasma-addons to ~/kde/usr, and then restart plasmashell. This works for testing everything else.