Differential D24717

[Advanced Settings] Clean up UI file
Needs RevisionPublic
Actions

Authored by broulik on Oct 16 2019, 9:42 PM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Summary

Remove pointless outer layout and spacer items.

BUG: 412971
FIXED-IN: 5.17.1

Test Plan

Looks almost the same still, haven't tested on Qt 5.14.
Should probably use two flat QGroupBoxes instead but the "Battery levels" label uses HTML <b> to become bold and excess whitespace at the end, i.e. would require string changes, so this is good enough for stable.

Diff Detail

Repository
R122 Powerdevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 16 2019, 9:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2019, 9:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 16 2019, 9:42 PM
mart accepted this revision.Oct 17 2019, 9:03 AM
This revision is now accepted and ready to land.Oct 17 2019, 9:03 AM
davidedmundson requested changes to this revision.Oct 17 2019, 9:08 AM

Looks the same as in, the bug on Qt5.14 is still there.

Though this is an improvement, so feel free to ship it.

This revision now requires changes to proceed.Oct 17 2019, 9:08 AM

Revision Contents
Changeset List

PathPackages
Mkcmodule/global/generalPage.ui (332 lines)

Diff 68094

View Options

kcmodule/global/generalPage.ui

Loading...