Differential D24714

[effects/startupfeedback] Scale application icon size with cursor size
ClosedPublic
Actions

Authored by broulik on Oct 16 2019, 9:12 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:2497f901d712: [effects/startupfeedback] Scale application icon size with cursor size
Summary

KWin doesn't use Qt scaling and as such the icon remains tiny.
Instead, make it follow the cursor size as the user is likely to have larger cursors on high dpi.

Test Plan
  • I can actually see my bouncy cursor now
  • also works with blinking

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 16 2019, 9:12 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 16 2019, 9:12 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Oct 16 2019, 9:12 PM
broulik edited reviewers, added: KWin; removed: kwinslet.
zzag added a subscriber: zzag.Oct 17 2019, 7:42 AM
zzag added inline comments.
effects/startupfeedback/startupfeedback.cpp
287

What's this 1.5 factor?

broulik added inline comments.Oct 17 2019, 7:42 AM
effects/startupfeedback/startupfeedback.cpp
287

Normal cursor size is 24, normal small icon size is 16.

zzag accepted this revision.Oct 17 2019, 8:00 AM
This revision is now accepted and ready to land.Oct 17 2019, 8:00 AM
Closed by commit R108:2497f901d712: [effects/startupfeedback] Scale application icon size with cursor size (authored by broulik). · Explain WhyOct 17 2019, 5:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68173

View Options

effects/startupfeedback/startupfeedback.cpp

Loading...