[Updates page] Add text to the checkbox instead of putting it in a separate label
ClosedPublic

Authored by ngraham on Oct 16 2019, 8:43 PM.

Details

Test Plan

Works fine and clicking on the text now toggles the checkbox.

Diff Detail

Repository
R134 Discover Software Store
Branch
real-checkbox-text (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17776
Build 17794: arc lint + arc unit
ngraham created this revision.Oct 16 2019, 8:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2019, 8:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 16 2019, 8:43 PM
apol added a comment.Oct 16 2019, 10:44 PM

You can test using --backends dummy.
To enable the build of the dummy backend, you pass -DBUILD_DummyBackend=ON to cmake.

ngraham edited the test plan for this revision. (Show Details)Oct 16 2019, 11:26 PM
ngraham added a reviewer: broulik.

Thanks!

apol accepted this revision.Oct 17 2019, 12:38 AM
This revision is now accepted and ready to land.Oct 17 2019, 12:38 AM
This revision was automatically updated to reflect the committed changes.