[Mouse KCM] Fix acceleration profile on X11
ClosedPublic

Authored by miraiko on Oct 16 2019, 8:36 PM.

Details

Summary

LIBINPUT_PROP_ACCEL_PROFILE_ENABLED contains two values,
valueWriterPart<bool> function didn't handle it correctly.

BUG: 398713
FIXED-IN: 5.17.1

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
miraiko requested review of this revision.Oct 16 2019, 8:36 PM
miraiko created this revision.

Thanks for submitting this patch!

What exactly do you mean by "now"? Did this change recently?

ngraham edited the summary of this revision. (Show Details)Oct 16 2019, 8:56 PM

Thank you for the review.

Did this change recently?

According to xf86-input-libinput git, this has been since 2015.
https://cgit.freedesktop.org/xorg/driver/xf86-input-libinput/commit/?id=0163482e22ad65ec51e3636cf31f9f39e29ff709
"Now" is a superfluous word here.

https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126
It should be changed also, right?
When you create a diff add a more context to it, like git diff -U100 > patch

miraiko updated this revision to Diff 68109.Oct 17 2019, 7:25 AM
romangg added a comment.EditedOct 21 2019, 8:55 PM

@miraiko Do you have an email address that should be used for the commit? Name Mirai Komachi, right?

romangg retitled this revision from KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver to [Mouse KCM] Fix acceleration profile on X11.Oct 21 2019, 9:21 PM
romangg edited the summary of this revision. (Show Details)
romangg updated this revision to Diff 68487.Oct 21 2019, 9:30 PM

Small code style change.

romangg accepted this revision.Oct 21 2019, 9:41 PM
This revision is now accepted and ready to land.Oct 21 2019, 9:41 PM
ngraham accepted this revision.Oct 21 2019, 10:44 PM

Lovely.

@miraiko Do you have an email address that should be used for the commit? Name Mirai Komachi, right?

ping @miraiko

This revision was automatically updated to reflect the committed changes.

@romangg sorry for the late reply, all is well, thanks.