Differential D24703

Port (most of) KSslInfoDialog from KSslError to QSslError
ClosedPublic
Actions

Authored by vkrause on Oct 16 2019, 4:26 PM.

Details

Reviewers
aacid
Maniphest Tasks
T11620: Port from KSslError to QSslError
Commits
R241:ba182f153729: Port (most of) KSslInfoDialog from KSslError to QSslError

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 16 2019, 4:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 16 2019, 4:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Oct 16 2019, 4:26 PM
aacid added a subscriber: aacid.Oct 22 2019, 8:56 PM
aacid added inline comments.
src/widgets/ksslinfodialog.h
82

Does this need to use the new deprecated since markers?

vkrause updated this revision to Diff 68619.Oct 23 2019, 4:37 PM

Adapt to the new deprecation macros.

aacid accepted this revision.Oct 23 2019, 8:15 PM
This revision is now accepted and ready to land.Oct 23 2019, 8:15 PM
Closed by commit R241:ba182f153729: Port (most of) KSslInfoDialog from KSslError to QSslError (authored by vkrause). · Explain WhyOct 24 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68708

View Options

src/core/ksslerror_p.h

Loading...
View Options

src/widgets/ksslinfodialog.h

Loading...
View Options

src/widgets/ksslinfodialog.cpp

Loading...