Differential D24696

don't crash on nullptr pdfOptionsPage
ClosedPublic
Actions

Authored by sitter on Oct 16 2019, 12:50 PM.

Details

Reviewers
aacid
Commits
R223:568f11b0678e: don't crash on nullptr pdfOptionsPage
Summary

same as in fbeff5ae7c2b27577d829839879b0966b5a3859a there may not be
a pdfOptionsPage when using print preview.

this fixes an exciting crash on our windows build when trying to print
preview

Test Plan

can't easily build on windows but the traceback definitely falls over 0x0000 on that line, so given context I am confident this fixes the crash

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 16 2019, 12:50 PM
Restricted Application added a project: Okular. · View Herald TranscriptOct 16 2019, 12:50 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
sitter requested review of this revision.Oct 16 2019, 12:50 PM
aacid accepted this revision.Oct 17 2019, 5:06 PM
This revision is now accepted and ready to land.Oct 17 2019, 5:06 PM
Closed by commit R223:568f11b0678e: don't crash on nullptr pdfOptionsPage (authored by sitter). · Explain WhyOct 21 2019, 9:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68412

View Options

generators/poppler/generator_pdf.cpp

Loading...