Show version information in about screen
ClosedPublic
Actions

Authored by broulik on Oct 16 2019, 11:31 AM.

Details

Reviewers

fvogt
ognarb

Group Reviewers

Plasma

Commits

R856:4b75dd4e2be0: Show version information in about screen

Summary

It can be useful to know what version of host you're using.
For older hosts, this information just isn't displayed as the getVersion call will never be answered and the <p> is hidden by default.

Test Plan

5.17 for the host side?

Diff Detail

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Oct 16 2019, 11:31 AM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2019, 11:31 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Oct 16 2019, 11:31 AM

Tried with old host, no observable change

This revision is now accepted and ready to land.Oct 16 2019, 11:36 AM

Closed by commit R856:4b75dd4e2be0: Show version information in about screen (authored by broulik). · Explain WhyOct 16 2019, 11:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		extension/_locales/en/messages.json (9 lines)
M		extension/extension.js (4 lines)
M		extension/options.html (6 lines)
M		extension/options.js (14 lines)
M		host/CMakeLists.txt (2 lines)
A	M	host/config-host.h.cmake (1 line)
M		host/settings.cpp (4 lines)