Ensure modifier locks and latches don't trigger the mod only shortcut
ClosedPublic

Authored by graesslin on Aug 17 2016, 6:45 AM.

Details

Summary

If caps lock is on the shift key should not trigger. Similar pressing
caps lock should neither on activation press nor on deactivation press
trigger the shortcut. Related to that are latched modifiers aka sticky
modifiers: if the modifier is still on after releasing the key the
shortcut should not trigger. We must assume the user wanted to use the
modifier to activate the modifier, not to activate the shortcut.

This change ensures that we don't track for modifier only shortcuts if
a modifier is active before press or after release.

The added test case demonstrates for caps lock, latched modifiers is
currently still untested. (Needs a way to mock it).

Test Plan

See test case for caps lock.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5990.Aug 17 2016, 6:45 AM
graesslin retitled this revision from to Ensure modifier locks and latches don't trigger the mod only shortcut.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptAug 17 2016, 6:45 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mart accepted this revision.Aug 19 2016, 8:45 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 19 2016, 8:45 AM
This revision was automatically updated to reflect the committed changes.