| fvogt | |
| davidedmundson | |
| apol |
| Plasma |
I just switched to openSUSE Tumbleweed and noticed that the session names in SDDM's
chooser don't include "X11" or "Wayland" like they do in other distros I've used before. This
makes it impossible to tell which one you're going to boot into.
This patch adds those identifiers into the translated string so it's always clear.
Ideally https://github.com/sddm/sddm/pull/997 would get done first, but even it it doesn't,
it's no big deal.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
See https://phabricator.kde.org/D22210 for a discussion about this.
Maybe @fvogt can shed some light on the situation.
We have https://github.com/sddm/sddm/pull/997 in sddm for consistency with non-Plasma sessions.
Thank, all that makes sense. Ideally https://github.com/sddm/sddm/pull/997 would get done first but I think this can go in now IMO. Better to be clear and redundant than confusing and terse, and developers who are the target users of this feature won't be confused if "Wayland" gets shown twice.
Ideally https://github.com/sddm/sddm/pull/997 would get done first.
Why would we want that first? It'd put us in the situation where we have two different things with the same name.
My understanding of the SDDM PR in question is that it removes the "(Wayland)" suffix, which is desirable for this PR because then the dev session wouldn't have the word "Wayland" in it twice.
@davidedmundson is this okay now given the decision in D22210? Or should we massage the strings some more?