install ftpd gem for KIO ftp tests
ClosedPublic

Authored by sitter on Oct 14 2019, 10:15 AM.

Details

Summary

simple gem implementing an ftp daemon to test against

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Oct 14 2019, 10:15 AM
sitter created this revision.
bcooksley accepted this revision.Oct 14 2019, 10:42 AM
bcooksley added a subscriber: bcooksley.

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

This revision is now accepted and ready to land.Oct 14 2019, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

It is in master now. Optional test deps do make me squeamish though :(

Thanks for confirming - yes, it's not ideal to have them optional.