Differential D24626

install ftpd gem for KIO ftp tests
ClosedPublic
Actions

Authored by sitter on Oct 14 2019, 10:15 AM.

Details

Reviewers
bcooksley
Group Reviewers
Sysadmin
Commits
R857:880dbae344e4: Install ftpd gem for KIO ftp tests.
Summary

simple gem implementing an ftp daemon to test against

Diff Detail

Repository
R857 CI System Tooling
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17671
Build 17689: arc lint + arc unit
sitter requested review of this revision.Oct 14 2019, 10:15 AM
sitter created this revision.
bcooksley accepted this revision.Oct 14 2019, 10:42 AM
bcooksley added a subscriber: bcooksley.

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

This revision is now accepted and ready to land.Oct 14 2019, 10:42 AM
Closed by commit R857:880dbae344e4: Install ftpd gem for KIO ftp tests. (authored by sitter, committed by bcooksley). · Explain WhyOct 14 2019, 10:48 AM
This revision was automatically updated to reflect the committed changes.
sitter added a comment.Oct 14 2019, 11:36 AM
In D24626#546854, @bcooksley wrote:

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

It is in master now. Optional test deps do make me squeamish though :(

bcooksley added a comment.Oct 15 2019, 9:31 AM

Thanks for confirming - yes, it's not ideal to have them optional.

Revision Contents
Changeset List

Diff 67884

View Options

system-images/suse-qt512/Dockerfile

Loading...
View Options

system-images/suse-qt513/Dockerfile

Loading...