Differential D24603

Port away from deprecated KDELibs4Support
ClosedPublic
Actions

Authored by ahmadsamir on Oct 12 2019, 11:26 PM.

Details

Reviewers
mlaurent
vkrause
Maniphest Tasks
T11566: Port kmenuedit away from kdelibs4support
Commits
R103:e3b8910670e3: Port away from deprecated KDELibs4Support
Summary

kmenuedit seems to work, adding new submenus and items

Diff Detail

Repository
R103 KMenu Editor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17631
Build 17649: arc lint + arc unit
ahmadsamir created this revision.Oct 12 2019, 11:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2019, 11:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahmadsamir requested review of this revision.Oct 12 2019, 11:26 PM
ahmadsamir added a comment.Oct 12 2019, 11:32 PM

Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.

mlaurent accepted this revision.Oct 13 2019, 7:56 AM
This revision is now accepted and ready to land.Oct 13 2019, 7:56 AM
vkrause accepted this revision.Oct 13 2019, 9:11 AM
vkrause added a subscriber: vkrause.

Thanks!

Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir). · Explain WhyOct 13 2019, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
Mbasictab.cpp (14 lines)
Mtreeview.cpp (16 lines)

Diff 67820

View Options

CMakeLists.txt

Loading...
View Options

basictab.cpp

Loading...
View Options

treeview.cpp

Loading...