Details
Details
- Reviewers
dfaure aacid - Maniphest Tasks
- T11620: Port from KSslError to QSslError
- Commits
- R241:77fce361d9ba: Port KSslErrorUiData to QSslError
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good, maybe i can even convince you to make fatalErrors and remainingErrors const?
Comment Actions
This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem until the kssld side is ported too, but it nevertheless needs a workaround until that is done.
Comment Actions
Deal with errors with full QSslError level of detail until kssld is ported, make variables const.
Comment Actions
There's almost no test coverage for this unfortunately, and yes, I'd feel much better if we had that. I looked at adding tests as part of this work, but unfortunately that is rather complicated as there is a D-Bus daemon involved.