Port KSslErrorUiData to QSslError
ClosedPublic

Authored by vkrause on Oct 12 2019, 10:35 AM.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 12 2019, 10:35 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 12 2019, 10:35 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Oct 12 2019, 10:35 AM
aacid accepted this revision.Oct 12 2019, 10:34 PM
aacid added a subscriber: aacid.

Looks good, maybe i can even convince you to make fatalErrors and remainingErrors const?

This revision is now accepted and ready to land.Oct 12 2019, 10:34 PM
vkrause planned changes to this revision.Oct 13 2019, 8:57 AM

This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem until the kssld side is ported too, but it nevertheless needs a workaround until that is done.

vkrause updated this revision to Diff 67828.Oct 13 2019, 9:06 AM

Deal with errors with full QSslError level of detail until kssld is ported, make variables const.

This revision is now accepted and ready to land.Oct 13 2019, 9:06 AM
aacid accepted this revision.Oct 13 2019, 3:32 PM

Do we have tests for the thing you discovered breaks? Do we need them?

Do we have tests for the thing you discovered breaks? Do we need them?

There's almost no test coverage for this unfortunately, and yes, I'd feel much better if we had that. I looked at adding tests as part of this work, but unfortunately that is rather complicated as there is a D-Bus daemon involved.

This revision was automatically updated to reflect the committed changes.