Differential D24580

Fix minor EBN issues
ClosedPublic
Actions

Authored by yurchor on Oct 12 2019, 6:50 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:f9355ee60637: Fix minor EBN issues
Summary

Include duplication, no newline at the end of file and missing argument to the i18n() call

Test Plan

Should work fine but needs a review for i18n() calls

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17594
Build 17612: arc lint + arc unit
yurchor created this revision.Oct 12 2019, 6:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2019, 6:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.Oct 12 2019, 6:50 AM
apol accepted this revision.Oct 12 2019, 2:40 PM
apol added a subscriber: apol.

LGTM

This revision is now accepted and ready to land.Oct 12 2019, 2:40 PM
Closed by commit R120:f9355ee60637: Fix minor EBN issues (authored by yurchor). · Explain WhyOct 12 2019, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67760

View Options

applets/kicker/plugin/draghelper.cpp

Loading...
View Options

dataengines/geolocation/location_ip.cpp

Loading...
View Options

ksmserver/main.cpp

Loading...