All the new QML KCMs have their library in kcms/ subfolder
Also improve error reporting a bit by reporting whether the library was not found or its symbol is missing.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:5e7e87ca95e7: [kcminit] Additionally look in kcms/ folder for KCM plugins
Ran kcminit with D24361 and got kcm_style executed
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Nice. Can you make this the preferred path for KCMs, in fact? That would improve life when testing a patch that moves a KCM to the kcms/ sub-folder.
Comment Actions
There's more than 80 kcm plugins in the root folder and roughly 30 in the kcms/ folder. I don't think that is feasible at this time, eventually, as we port them, perhaps, but not all at once right now.
Also, style kcm is the first one with a kcminit symbol that is moved, which is why this only now started being an issue.
Comment Actions
We don't have any KCMs that are duplicated in both locations though, right? What's the harm in looking in kcms/ first, and then if nothing is found, looking ine level below that?
Comment Actions
What's the harm in looking in kcms/ first, and then if nothing is found, looking ine level below that?
As effectively all kcminit KCMs are in the root folder. Once that changes, we can flip it around.