Details
Details
- Reviewers
ngraham meven - Maniphest Tasks
- T10611: Set options for GTK apps in the respective KCMs
- To test gtk3 applications reloading on X11, install xsettingsd.
- After installing, restart kded5.
- Open gtk2 app, gtk3 app and open icon theme kcm.
- Change Icon Theme and check if earlier opened applications are changing their icons in UI after hitting Apply
- Reopen gtk applications to check if configuration is applied
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- gtk-config-icon-theme
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17541 Build 17559: arc lint + arc unit
Comment Actions
Apart from the small nitpick seems good to me.
gtkconfig/kded/configeditor.cpp | ||
---|---|---|
51 | Could you reset this file changes since it is only empty lines. |
Comment Actions
Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands.
Comment Actions
Do you mind if I make removal of cursor theme AND icon theme in one patch (after I add cursor theme to gtk daemon). That's because in kde-gtk-config cursors depend on icons in code (this is used only for previews). Also this combined patch can remove the whole category in kcm. If I left only cursors it looks odd.