Set an icon theme for gtk applications in the icons kcm
AbandonedPublic

Authored by gikari on Oct 10 2019, 6:55 PM.

Details

Summary

This is the addition to the D21860 for changing icon theme automatically as well

Depends on D21860

Test Plan
  1. To test gtk3 applications reloading on X11, install xsettingsd.
  2. After installing, restart kded5.
  3. Open gtk2 app, gtk3 app and open icon theme kcm.
  4. Change Icon Theme and check if earlier opened applications are changing their icons in UI after hitting Apply
  5. Reopen gtk applications to check if configuration is applied

Diff Detail

Repository
R119 Plasma Desktop
Branch
gtk-config-icon-theme
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17541
Build 17559: arc lint + arc unit
gikari created this revision.Oct 10 2019, 6:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2019, 6:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Oct 10 2019, 6:55 PM
gikari edited the test plan for this revision. (Show Details)Oct 10 2019, 6:56 PM
GB_2 awarded a token.Oct 10 2019, 6:59 PM
gikari updated this revision to Diff 67659.Oct 10 2019, 9:31 PM

Rebase on fixes from D21860

gikari updated this revision to Diff 67664.Oct 10 2019, 9:37 PM

Change brace initialization to curly bracket one

meven accepted this revision.Oct 11 2019, 8:25 AM
meven added a subscriber: meven.

Apart from the small nitpick seems good to me.

gtkconfig/kded/configeditor.cpp
51

Could you reset this file changes since it is only empty lines.

This revision is now accepted and ready to land.Oct 11 2019, 8:25 AM
gikari updated this revision to Diff 67685.Oct 11 2019, 9:00 AM

Add QStiringLiteral around const strings

gikari updated this revision to Diff 67688.Oct 11 2019, 9:12 AM

Remove empty lines

gikari marked an inline comment as done.Oct 11 2019, 9:13 AM
gikari updated this revision to Diff 67689.Oct 11 2019, 9:27 AM

Remove unnesasary comment

Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands.

Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands.

Do you mind if I make removal of cursor theme AND icon theme in one patch (after I add cursor theme to gtk daemon). That's because in kde-gtk-config cursors depend on icons in code (this is used only for previews). Also this combined patch can remove the whole category in kcm. If I left only cursors it looks odd.

All right, sure.

gikari abandoned this revision.Oct 17 2019, 6:46 PM

Abandoned in favor of D24743