[applets/taskmanager] Revert "forceStripes" checkbox string change
ClosedPublic

Authored by filipf on Oct 10 2019, 2:05 PM.

Details

Summary

I changed the "forceStripes" checkbox string in D19280, most likey because I thought it wasn't super understandable.

The new string I pushed doesn't, however, match what the option does.

So reverting the change.

BUG: 412801

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Oct 10 2019, 2:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2019, 2:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Oct 10 2019, 2:05 PM
filipf added a subscriber: ngraham.

I still think the string could be improved some, maybe @ngraham has an idea.

But the question is can this land in 5.17 given it's a string change? (albeit just a revert)

"rows of as many columns"

I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together.

"rows of as many columns"

I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together.

Yeah that was me as well when I made the string change :)

But I think(?) I understand now. I think it says "look, you've defined the maximum no. of rows/columns, do you want me to arrange tasks in as many columns/rows as you've just defined".

I can't quite come up with something that doesn't sound clunky, but IMO we don't need the "always".

After playing around with this option with my IOTM at various panel widths and various "maximum rows/columns" values, I still cannot for the life of me figure out what on earth it does--or else the feature is so buggy I'm unable to discover the pattern.

Original commit: https://git.reviewboard.kde.org/r/123738/

(following it through quite a few renames)

From what I can tell, it's akin to the direction property in a Flow

ngraham accepted this revision.Oct 10 2019, 4:42 PM

Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now (if translators approve) and work on a better string (or even a better UI) for Plasma 5.18.

This revision is now accepted and ready to land.Oct 10 2019, 4:42 PM

Idea for a better string: "Fill each row/column before adding tasks to the next row/column"

aspotashev accepted this revision.Oct 10 2019, 4:58 PM

The changes in messages are indeed reverted by this patch.

FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, in addition to landing it on the stable branch, @jriddell will have to do some release magic to include it and you'll want to ping him about that.

Original commit: https://git.reviewboard.kde.org/r/123738/

(following it through quite a few renames)

From what I can tell, it's akin to the direction property in a Flow

I guess "Always arrange tasks in columns of as many rows" was meant to be "Always arrange tasks in columns of as many rows as possible". However this still sounds complicated.

Plasma folder view has a similar algorithm for arranging icons (either top-to-bottom or left-to-right), here is how to access it in the UI:

, may be reasonable to reuse this wording "Arrange in ... Rows/Columns".

Do we have a green light for 5.17.1? How do I tag the translators?

@aspotashev is a translator and he's approved, so I'd say you're good to go.

Before pushing new i18n strings into stable branches, you need to ask for permission in https://mail.kde.org/mailman/listinfo/kde-i18n-doc

Altough one translator's approval is enough, writing to kde-i18n-doc is also important to notify the other translation teams for them not to miss the update.

This revision was automatically updated to reflect the committed changes.