Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer
ClosedPublic

Authored by davidre on Oct 10 2019, 1:28 PM.

Diff Detail

Repository
R124 System Settings
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17507
Build 17525: arc lint + arc unit
davidre created this revision.Oct 10 2019, 1:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2019, 1:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Oct 10 2019, 1:28 PM
davidre edited the test plan for this revision. (Show Details)Oct 10 2019, 1:30 PM
davidre added reviewers: Plasma, VDG.
filipf added a subscriber: filipf.Oct 10 2019, 2:31 PM

Looks good to me, although a little bit empty. If I was designing this in a vacuum I would add the equivalent of a row layout, put the label in it and then a separator after it. What do you think, would it be too inconsistent with our other header style?

Do you mean the equivalent of a column layout, with a horizontal line under the title?

Do you mean the equivalent of a column layout, with a horizontal line under the title?

This sort of a style, the line is right next to the title.

GB_2 added a subscriber: GB_2.Oct 12 2019, 6:43 PM

This sort of a style, the line is right next to the title.

Hmm, I think that would be too inconsistent again. Current version looks good to me.

GB_2 accepted this revision as: VDG, GB_2.Oct 12 2019, 6:52 PM
GB_2 edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 12 2019, 6:53 PM
This revision was automatically updated to reflect the committed changes.