[XembedSNIProxy] If available, always use 32-bit color.
ClosedPublic

Authored by kmaterka on Oct 10 2019, 10:02 AM.

Details

Summary

If available, always use 32-bit color. We don't need Composite extension to handle transparency - all client windows are our children and transparency in handled in QML, inside the panel (so no need to composite real windows).

BUG: 356937
FIXED-IN: 5.17.1

Test Plan

Disable compositor, run:

  • pidgin (make sure pidgin-libnotify is NOT installed)
  • keepassx
  • xchat
  • liferea

Before changes: black backgroud
After changes: transparent background

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Oct 10 2019, 10:02 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2019, 10:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 10 2019, 10:02 AM

Needs to be applied after D24514

D24514 is merged, this one should apply smoothly now.

ngraham edited the summary of this revision. (Show Details)Oct 10 2019, 3:09 PM
kmaterka added a comment.EditedOct 14 2019, 8:24 AM

I have Developer Account now. Is review finished or something more is needed? Can I push this change?

Hi,
You can't commit yet as nobody accepted this patch.
Regards

davidedmundson accepted this revision.Oct 14 2019, 9:46 AM
This revision is now accepted and ready to land.Oct 14 2019, 9:46 AM

You can merge now :)

This revision was automatically updated to reflect the committed changes.

FWIW since you landed this on master rather than Plasma/5.17, it will only be in Plasma 5.18, not 5.17.1.

At this point, if it's critical to go into 5.17.1, you should cherry-pick the commit onto the Plasma/5.17 branch since landing it there and merging forward is no longer possible.

FWIW since you landed this on master rather than Plasma/5.17, it will only be in Plasma 5.18, not 5.17.1.

At this point, if it's critical to go into 5.17.1, you should cherry-pick the commit onto the Plasma/5.17 branch since landing it there and merging forward is no longer possible.

It is not critical, it can wait for 5.18.