This fix work only after applying other patch (but fix an issue that exist on master) (24519)
Bug: When you go to the kcm cursor, if you go hover a theme the "real" cursor change to show a preview. After applying a new theme the preview don't work anymore before you change the cursor size.
In order to work we need a call to setTheme that is done by setCursorSize.
Currently the if (m_currentSize == size) prevent the call to setTheme, so I removed it and removed the unused signal
Details
Details
- Reviewers
mart ervin davidedmundson - Group Reviewers
Plasma - Commits
- R119:8b2f75f13e0e: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I don't understand this patch in relation to the title.
If no-one uses this property this shouldn't make a difference?
Comment Actions
Overall this doesn't look like the proper fix to me. A setter should not do anything if we pass the current value to it. From your description it seems to indicate that a call to setTheme is missing in some situations, I think it'd lead to a better fix if the exact condition when this happens is determined and then the extra setTheme call inserted just then. Changing a setter semantic to get a side-effect looks wrong to me.
kcms/cursortheme/xcursor/previewwidget.h | ||
---|---|---|
34 | I'd keep it as is for the reasons I mentioned in another patch: avoid write only properties, it's really annoying on the QML side. |