I think this will be broken if you change this combo box, then change theme.
When a user explicitly changes this combo box this binding gets broken with currentIndex now reflecting an explicit number.
On theme change cursorThemeSettings.cursorSize changes correctly but our binding is gone.
This might have to be a connection again
int, not const inst
This is rather unusual, could we have a full fledged property here despite the boilerplate? I'm thinking of the future developer who might get bitten when changing the QML code and having a half working property.
int, not const int
s/row/index/ I'd say.
nitpick: Please add an empty line after that one.
David has a point, the binding of currentIndex will be broken as soon as the user changes the entry in the combo box.
That being said, IIRC this shouldn't matter much in that context though, because we seem to be just after pre-selecting the right entry in the combo box when the module is displayed and not always enforcing a currentIndex value (which we can't in the context of combo box as David pointed out).
What matters is that the settings get properly updated when the user select a new entry in the combo box which is handled with onActivated just fine.
|25 ↗||(On Diff #67561)|
Why is that include added? This doesn't seem necessary to me.