Differential D24518

On KCM cursor theme update attribute name
ClosedPublic
Actions

Authored by bport on Oct 9 2019, 2:36 PM.

Details

Reviewers
mart
ervin
davidedmundson
Group Reviewers
Plasma
Commits
R119:186ab6e9b75e: On KCM cursor theme update attribute name
Summary

Rename m_model to m_themeModel and selectedIndex to themeSelectedIndex
to avoid confusion because we have two models in this class.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 17512
Build 17530: arc lint + arc unit
bport created this revision.Oct 9 2019, 2:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2019, 2:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Oct 9 2019, 2:36 PM
davidedmundson accepted this revision.Oct 9 2019, 3:03 PM
This revision is now accepted and ready to land.Oct 9 2019, 3:03 PM
ervin requested changes to this revision.Oct 9 2019, 8:12 PM
ervin added inline comments.
kcms/cursortheme/kcmcursortheme.cpp
383

This seems unrelated to that change. Did you mean to have that in the previous commit?

This revision now requires changes to proceed.Oct 9 2019, 8:12 PM
bport updated this revision to Diff 67608.Oct 10 2019, 1:51 PM

Remove change not related to this commit

bport marked an inline comment as done.Oct 10 2019, 1:51 PM
ervin accepted this revision.Oct 15 2019, 8:49 AM
This revision is now accepted and ready to land.Oct 15 2019, 8:49 AM
Closed by commit R119:186ab6e9b75e: On KCM cursor theme update attribute name (authored by bport). · Explain WhyOct 15 2019, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67608

View Options

kcms/cursortheme/kcmcursortheme.h

Loading...
View Options

kcms/cursortheme/kcmcursortheme.cpp

Loading...