[XembedSNIProxy] Do not crash on null pointer
ClosedPublic

Authored by kmaterka on Wed, Oct 9, 12:03 PM.

Details

Summary

XCB may return null pointer as a response. Add a check to prevent
segmentation fault.

BUG: 409652
FIXED-IN: 5.17.1

Test Plan

It is hard to reproduce, but the reason of the segmentation fault is pretty obvious, thanks to the debug dump from bug 409652

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Wed, Oct 9, 12:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Oct 9, 12:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Wed, Oct 9, 12:03 PM

+few minor code style changes

davidedmundson accepted this revision.Wed, Oct 9, 12:29 PM
This revision is now accepted and ready to land.Wed, Oct 9, 12:29 PM
kmaterka edited the test plan for this revision. (Show Details)Wed, Oct 9, 1:46 PM
ngraham added a subscriber: ngraham.Wed, Oct 9, 4:50 PM

Does this really fix 356937? That seems to be about something other than a crash. Did you mean 409652 instead?

kmaterka edited the summary of this revision. (Show Details)Thu, Oct 10, 10:36 AM

Does this really fix 356937? That seems to be about something other than a crash. Did you mean 409652 instead?

Yes, sorry, copy & paste error. I'm working on several bus related to XEmbedSNIProxy now :)

kmaterka edited the summary of this revision. (Show Details)Thu, Oct 10, 10:37 AM
ngraham edited the summary of this revision. (Show Details)Thu, Oct 10, 1:26 PM
ngraham edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.