Simplify get_po_path
ClosedPublic

Authored by adrianchavesfernandez on Oct 9 2019, 10:08 AM.

Details

Test Plan

Untested

Diff Detail

Branch
/trunk/l10n-kf5/scripts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17471
Build 17489: arc lint + arc unit
adrianchavesfernandez requested review of this revision.Oct 9 2019, 10:08 AM
adrianchavesfernandez created this revision.
get_paths
125

I believe this needs to be here to match before kdesupport_* below does. I wonder if I should include a comment about it, to make it more obvious, since it is not easy to spot kdesupport_* below.

128

This line is no longer repeated multiple times.

aacid added inline comments.Oct 10 2019, 8:30 PM
get_paths
127

This is broken

kdewebdev_*pim_*||

Fix broken code reported by aacid

aacid added inline comments.Oct 23 2019, 10:47 PM
get_paths
125

There's no kdesupport_* anymore that i can find

Actually list_modules only says

kdesupport-phonon_phonon 
kdesupport-phonon_phonon-gstreamer
kdesupport-phonon_phonon-vlc

so may as well remove the one from below if it bothers you.

adrianchavesfernandez marked an inline comment as done.

Remove kdesupport_*

This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2019, 8:13 AM
Closed by commit R883:1554509: Simplify get_po_path (authored by adrianchavesfernandez, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.