Differential D24511

Simplify get_po_path
ClosedPublic
Actions

Authored by adrianchavesfernandez on Oct 9 2019, 10:08 AM.

Details

Reviewers
aacid
ltoscano
Commits
R883:1554509: Simplify get_po_path
Test Plan

Untested

Diff Detail

Repository
R883 Subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adrianchavesfernandez requested review of this revision.Oct 9 2019, 10:08 AM
adrianchavesfernandez created this revision.
adrianchavesfernandez added inline comments.Oct 9 2019, 10:10 AM
get_paths
125 ↗(On Diff #67538)

I believe this needs to be here to match before kdesupport_* below does. I wonder if I should include a comment about it, to make it more obvious, since it is not easy to spot kdesupport_* below.

128 ↗(On Diff #67538)

This line is no longer repeated multiple times.

aacid added inline comments.Oct 10 2019, 8:30 PM
get_paths
127 ↗(On Diff #67538)

This is broken

kdewebdev_*pim_*||

adrianchavesfernandez updated this revision to Diff 68316.Oct 19 2019, 10:46 PM

Fix broken code reported by aacid

aacid added inline comments.Oct 23 2019, 10:47 PM
get_paths
125 ↗(On Diff #67538)

There's no kdesupport_* anymore that i can find

Actually list_modules only says

kdesupport-phonon_phonon 
kdesupport-phonon_phonon-gstreamer
kdesupport-phonon_phonon-vlc

so may as well remove the one from below if it bothers you.

adrianchavesfernandez updated this revision to Diff 68810.Oct 27 2019, 8:12 AM
adrianchavesfernandez marked an inline comment as done.

Remove kdesupport_*

This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2019, 8:13 AM
Closed by commit R883:1554509: Simplify get_po_path (authored by adrianchavesfernandez, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtrunk/l10n-kf5/scripts/get_paths (26 lines)

Diff 68811

View Options

trunk/l10n-kf5/scripts/get_paths

Loading...