Fix build against Qt without std::hash<QString> specialization
ClosedPublic
Actions

Authored by dvratil on Oct 8 2019, 11:35 AM.

Details

Reviewers

Commits

R45:496047cdfd1c: Fix build against Qt without std::hash<QString> specialization

Summary

std::hash specializations for some Qt types were introduced in
Qt 5.14, it appears. To build against older Qt we need to specialize
std::hash ourselves.

Test Plan

Master builds against Qt 5.12.5

Diff Detail

Repository

R45 Heaptrack

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil requested review of this revision.Oct 8 2019, 11:35 AM

dvratil created this revision.

Harbormaster completed remote builds in B17438: Diff 67491.Oct 8 2019, 11:35 AM

dvratil edited the summary of this revision. (Show Details)Oct 8 2019, 11:36 AM

thanks

This revision is now accepted and ready to land.Oct 8 2019, 6:42 PM

Closed by commit R45:496047cdfd1c: Fix build against Qt without std::hash<QString> specialization (authored by dvratil). · Explain WhyOct 9 2019, 8:40 AM

This revision was automatically updated to reflect the committed changes.

beischer mentioned this in D24532: Declare new hash function in namespace std in order to fix build..Oct 10 2019, 1:18 PM

Revision Contents
Changeset List

			Path	Packages
M			src/analyze/gui/parser.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67491	8df827a		Oct 8 2019, 11:35 AM	★	★
Diff 2	67530	8df827a	R45:496047cdfd1c77d1cea7b923fc8beb22dd2daac0	Oct 9 2019, 8:07 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f169fa6c84a9	845638d9b301	8df827a28181	Daniel Vrátil	Fix build against Qt without std::hash<QString> specialization (Show More…)	Oct 8 2019, 11:35 AM

Diff 67530

View Options

src/analyze/gui/parser.cpp