KAutosaveFile not respecting maximum filename length
Needs ReviewPublic

Authored by mardelle on Tue, Oct 8, 11:16 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

There are 2 different issues in current code regarding maximum filename length:

1- We use FILENAME_MAX which is defined as 4096, while most filesystems have a max length of 256. Replacing FILENAME_MAX with NAME_MAX fixes this first problem (could not test on Windows if it works)

2- We are calculating the maximum length on the UTF-8 string, then encoding to percent encoding. This can result in longer strings since single characters will be replaced by a percent string. So in some situations, we end up with a string longer than allowed. Doing the percent encoding before length calculation fixes the problem.

This fixes the follwing bug: https://bugs.kde.org/show_bug.cgi?id=412519

Test Plan

Bug is fixed with the changes

Diff Detail

Repository
R244 KCoreAddons
Lint
Lint Skipped
Unit
Unit Tests Skipped
mardelle created this revision.Tue, Oct 8, 11:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. ยท View Herald TranscriptTue, Oct 8, 11:16 AM
mardelle requested review of this revision.Tue, Oct 8, 11:16 AM