use dbus interface to switch shell l&f
ClosedPublic

Authored by mart on Aug 15 2016, 12:15 PM.

Details

Summary

the shell has 2 methods to switch lnf layout:
one that throws away the config contents, one that
keeps them

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 5926.Aug 15 2016, 12:15 PM
mart retitled this revision from to use dbus interface to switch shell l&f.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2016, 12:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 15 2016, 12:22 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kcms/lookandfeel/kcm.cpp
33

unused

257

if you're not going to handle the reply at all

.call(message, QDBus::NoBlock)
is better

This revision is now accepted and ready to land.Aug 15 2016, 12:22 PM
mart updated this revision to Diff 5929.Aug 15 2016, 12:26 PM
mart edited edge metadata.
  • use .call(message, QDBus::NoBlock)
mart updated this revision to Diff 6033.Aug 18 2016, 2:07 PM
  • be more verbose on what the kcm is doing
mart updated this revision to Diff 6035.Aug 18 2016, 2:11 PM
  • typo

UI-wise, I'd do it differently.
Currently, the description of what the checkbox affects and the checkbox itself are too far separated, plus it makes it sound like the layout is going to be changed even if the checkbox is not checked. Instead what I'd do is, below the general description paragraph (above the actual selection), put

[ ] Change the workspace layout to the one in the selected theme

unchecked by default, and if it's checked, show directly below
"Warning: When clicking "Apply", your current workspace layout (including all panels and desktop widgets) will be irrevocably lost and changed to the one defined in the Look & Feel theme."

mart added a comment.Aug 18 2016, 3:29 PM

UI-wise, I'd do it differently.
Currently, the description of what the checkbox affects and the checkbox itself are too far separated, plus it makes it sound like the layout is going to be changed even if the checkbox is not checked. Instead what I'd do is, below the general description paragraph (above the actual selection), put

[ ] Change the workspace layout to the one in the selected theme

that will always happen, for how the architecture is done now i have no way to make it not switch the layout, neither i would have any idea how to make this configurable

the checkbox is between throwing away any change the user may have done or not

mart updated this revision to Diff 6038.Aug 18 2016, 4:51 PM
  • switch to single config file
This revision was automatically updated to reflect the committed changes.