feedback kcm: Use a horizontal slider like GammaRay does
ClosedPublic

Authored by apol on Oct 7 2019, 1:56 PM.

Details

Summary

Instead of a combo box, which is a bit harder on the wording.
Also get more texts from kuserfeedback itself, no reason to translate twice.

Test Plan

Tested manually

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17425
Build 17443: arc lint + arc unit
apol created this revision.Oct 7 2019, 1:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 7 2019, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Oct 7 2019, 1:56 PM
ngraham accepted this revision.Oct 7 2019, 3:17 PM
This revision is now accepted and ready to land.Oct 7 2019, 3:17 PM
broulik added a subscriber: broulik.Oct 7 2019, 3:21 PM
broulik added inline comments.
kcms/feedback/package/contents/ui/main.qml
79

Use Array.findIndex

84–85

Use onMoved which is the slider equivalent to onActivated

apol marked 2 inline comments as done.Oct 7 2019, 10:44 PM
apol updated this revision to Diff 67471.Oct 7 2019, 10:46 PM

Address kai's comments

apol updated this revision to Diff 67472.Oct 7 2019, 10:50 PM

ehm, typo

broulik added inline comments.Oct 8 2019, 12:16 PM
kcms/feedback/package/contents/ui/main.qml
79

Unused

broulik accepted this revision.Oct 8 2019, 12:16 PM
This revision was automatically updated to reflect the committed changes.