Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 7 2019, 1:27 PM.

Details

Reviewers

dfaure
mlaurent

Group Reviewers

Frameworks

Commits

Summary

Allows

projects linking to KParts to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKPARTS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKPARTS_NO_DEPRECATED
- -DKPARTS_DEPRECATED_WARNINGS_SINCE
- -DKPARTS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KParts optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

Repository

R306 KParts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Oct 7 2019, 1:27 PM

If no-one objects, would be pushing on Monday evening, Oct. 14th.

This revision is now accepted and ready to land.Oct 12 2019, 6:58 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (4 lines)
M			src/CMakeLists.txt (10 lines)
M			src/browserextension.h (2 lines)
M			src/browserrun.h (15 lines)
M			src/browserrun.cpp (4 lines)
M			src/readonlypart.h (10 lines)
M			src/readonlypart.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67430	1116a3c		Oct 7 2019, 1:27 PM	★	★
Diff 2	67732	1116a3c	* disable KF group deprecation macros for now	Oct 11 2019, 5:28 PM	★	★
Diff 3	67810	1116a3c	R306:b8bc88232471db3643ab632cc1efa80642b07137	Oct 12 2019, 9:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
545362fbd0cc	b11207d1ce68	1116a3c8d4b1	Friedrich W. H. Kossebau	Use ECMGenerateExportHeader to manage deprecated API better (Show More…)	Sep 27 2019, 1:28 PM