Differential D24451

metadata: Add form factors to make kcm appear on mobile again
ClosedPublic
Actions

Authored by jbbgameich on Oct 6 2019, 11:41 PM.

Details

Reviewers
nicolasfella
bshah
Group Reviewers
Plasma: Mobile
Plasma
Commits
R115:91e6cf9694cd: metadata: Add form factors to make kcm appear on mobile again
Summary

Seems to be required to make the kcm visible in plasma-settings

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
mobile (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17375
Build 17393: arc lint + arc unit
jbbgameich created this revision.Oct 6 2019, 11:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 6 2019, 11:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Oct 6 2019, 11:41 PM
nicolasfella accepted this revision.Oct 6 2019, 11:52 PM
This revision is now accepted and ready to land.Oct 6 2019, 11:52 PM
bshah accepted this revision.Oct 7 2019, 12:48 AM
bshah added a subscriber: bshah.

Please commit to 5.17 as well.

jbbgameich added a comment.Oct 7 2019, 6:44 AM

Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 branch back into master?

Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm appear on mobile again (authored by jbbgameich). · Explain WhyOct 7 2019, 6:44 AM
This revision was automatically updated to reflect the committed changes.
bshah added a comment.Oct 7 2019, 6:45 AM

Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 branch back into master?

Generally you merge the branch back in master, but I've done it (metadata.desktop file of package also needed updating).

Revision Contents
Changeset List

PathPackages
Msrc/kcm/kcm_pulseaudio.desktop (1 line)

Diff 67400

View Options

src/kcm/kcm_pulseaudio.desktop

Loading...