Differential D24447

Fix compatibility of build_theme.sh with Dash
ClosedPublic
Actions

Authored by gepardo on Oct 6 2019, 8:45 PM.

Details

Reviewers
cblack
svuorela
Commits
R98:91c16f284c18: Fix compatibility of build_theme.sh with Dash
Summary

The script build_sh didn't work with Dash necause of "[[". When running it, I got the following:

$ ./build_theme.sh
Installing into /home/gepardo/.local/share/themes/Breeze
./build_theme.sh: 111: [[: not found
cp: cannot create directory '': No such file or directory

Test Plan

After changing "[[" to "[", it worked fine and installed the theme

Diff Detail

Repository
R98 Breeze for Gtk
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17367
Build 17385: arc lint + arc unit
gepardo created this revision.Oct 6 2019, 8:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 6 2019, 8:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gepardo requested review of this revision.Oct 6 2019, 8:45 PM
svuorela accepted this revision.Oct 15 2019, 6:48 PM
This revision is now accepted and ready to land.Oct 15 2019, 6:48 PM
cblack accepted this revision.Oct 15 2019, 7:44 PM

LGTM 👍

gepardo added a comment.Oct 15 2019, 7:47 PM

Thanks. Can you please merge it? I don't have a developer access to KDE repos.

cblack added a comment.Oct 15 2019, 7:48 PM
In D24447#547774, @gepardo wrote:

Thanks. Can you please merge it? I don't have a developer access to KDE repos.

Sure, I'll do that.

Closed by commit R98:91c16f284c18: Fix compatibility of build_theme.sh with Dash (authored by gepardo, committed by cblack). · Explain WhyOct 15 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/build_theme.sh (2 lines)

Diff 67392

View Options

src/build_theme.sh

Loading...