Differential D24444

Remove KDEGAMES_EXPORT
ClosedPublic
Actions

Authored by twighk on Oct 6 2019, 3:08 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R411:865a87c53146: Fix compile on Windows (more)
Summary

KDEGAMES_EXPORT Macro causes many linking errors when compiling with craft on windows using mingw.

for example:
CMakeFiles/kreversi.dir/highscores.cpp.obj: In function `KExtHighscore::ExtManager::ExtManager()':
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:33: undefined reference to `impZN13KExtHighscore7Ma
nagerC2Ejj'
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:35: undefined reference to `impZN13KExtHighscore7Ma
nager11setShowModeENS0_8ShowModeE'
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:36: undefined reference to `impZN13KExtHighscore7Ma
nager17setShowStatisticsEb'
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:37: undefined reference to `impZN13KExtHighscore7Ma
nager25setShowDrawGamesStatisticEb'
C:/CraftRoot/build/_/27965d37/kreversi-19.08.1/highscores.cpp:43: undefined reference to `impZN13KExtHighscore7Ma
nager17setScoreHistogramERK7QVectorIjENS0_14ScoreTypeBoundE'

Diff Detail

Repository
R411 KReversi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
twighk created this revision.Oct 6 2019, 3:08 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 6 2019, 3:08 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
twighk requested review of this revision.Oct 6 2019, 3:08 PM
aacid accepted this revision.Oct 7 2019, 9:16 PM
aacid added a subscriber: aacid.

Nice patch.

I see you've been working on getting things compiling on Windows, nice work :)

Do you know of the initiative we have for getting some applications to the Windows Store? Want to join?

This revision is now accepted and ready to land.Oct 7 2019, 9:16 PM
Closed by commit R411:865a87c53146: Fix compile on Windows (more) (authored by twighk, committed by aacid). · Explain WhyOct 7 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.
twighk added a comment.Oct 9 2019, 7:49 PM
In D24444#543333, @aacid wrote:

Nice patch.

I see you've been working on getting things compiling on Windows, nice work :)

Do you know of the initiative we have for getting some applications to the Windows Store? Want to join?

Thanks ! I didn't know there were any initatives, do you know where i could find more information about it?

Revision Contents
Changeset List

PathPackages
Mkexthighscore.h (16 lines)
Mkexthighscore_item.h (22 lines)

Diff 67463

View Options

kexthighscore.h

Loading...
View Options

kexthighscore_item.h

Loading...