Differential D24436

Add applications-network icon for renaming Internet category to Network
ClosedPublic
Actions

Authored by guoyunhe on Oct 6 2019, 9:39 AM.

Details

Reviewers
ndavis
Group Reviewers
Breeze
Commits
R266:87d712c7a0e2: Add applications-network icon for renaming Internet category to Network
Summary

See D24424

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17351
Build 17369: arc lint + arc unit
guoyunhe created this revision.Oct 6 2019, 9:39 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 6 2019, 9:39 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
guoyunhe requested review of this revision.Oct 6 2019, 9:39 AM
ndavis added a subscriber: ndavis.Oct 6 2019, 4:22 PM

If we're just renaming the category, we don't need to also rename the icon in this case. It would break compatibility with 3rd party icon themes and the only upside is a semantically better name.

guoyunhe added a comment.Oct 6 2019, 7:20 PM

They can easily rename/link the icon. Correct semantic naming can improve the icon design. In a long view, having the same naming from the freedestop.org specification, to KDE categories, to icons, can reduce confusion.

ndavis accepted this revision.Oct 6 2019, 9:17 PM

Eh, it doesn't bother me that much. If you think this is the right thing to do, go ahead.

This revision is now accepted and ready to land.Oct 6 2019, 9:17 PM
Closed by commit R266:87d712c7a0e2: Add applications-network icon for renaming Internet category to Network (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyOct 7 2019, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67364

View Options

icons-dark/categories/32/applications-network.svg

Loading...
View Options

icons/categories/32/applications-network.svg

Loading...